transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Change Paligemma import logging to work with modular

Open yonigozlan opened this issue 1 year ago • 0 comments

What does this PR do?

Currently, the modeling file of Paligemma uses from ...utils import logging, and the processing file uses import logging. That means if we want to use a modular file to add a model inheriting from Paligemma, depending on what import logging we add to the modular file, we either have:

  • An error as one logging is used to create a logger with logging.get_logger and the other with logging.getLogger
  • A style issue as logging is imported from two different places in the same file

I'm not sure if we want to modify modular transformers to handle this, or if it's better to enforce the use of the same logging module across the files of a model. Wdyt @ArthurZucker

yonigozlan avatar Oct 17 '24 08:10 yonigozlan