transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Raise warning for OOV tokens in fast tokenizer fix #29159

Open akkefa opened this issue 1 year ago • 1 comments

What does this PR do?

Fixes #29159

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

akkefa avatar Aug 21 '24 09:08 akkefa

cc @ArthurZucker @itazap

amyeroberts avatar Aug 22 '24 18:08 amyeroberts

BTW @akkefa before we review the PR, could you make sure you approve circle CI?

ArthurZucker avatar Aug 26 '24 09:08 ArthurZucker

BTW @akkefa before we review the PR, could you make sure you approve circle CI?

@ArthurZucker How I can approve circle CI flow?

akkefa avatar Aug 26 '24 13:08 akkefa

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.