transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Add changes for uroman package to handle non-Roman characters

Open nandwalritik opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes #32387

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case. #32387
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings. - No
  • [ ] Did you write any new necessary tests? - No

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @sanchit-gandhi @ylacombe

I have added the change for using uroman as optional dependency, just want to know if it's correctly implemented.

nandwalritik avatar Aug 03 '24 11:08 nandwalritik

Super first draft @nandwalritik! It's very close to being ready 🤗

My only issue with the PR is regarding backwards compatibility (explained below). Otherwise, my only request is slightly more verbose installation instructions in the docs.

Other than that, the PR looks great!

Just one doubt here, when I was installing uroman, It requires python version >=3.10. Do we need to mention it somewhere?

nandwalritik avatar Aug 07 '24 14:08 nandwalritik

Feel free to request a final review directly from @ArthurZucker when the last changes have been made @nandwalritik :)

sanchit-gandhi avatar Aug 07 '24 15:08 sanchit-gandhi

Hi @ArthurZucker can you give a final review to the PR, already updated docs as per sanchit's inputs for backward compatibility.

nandwalritik avatar Aug 08 '24 15:08 nandwalritik

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.