transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Refactor test fetcher

Open ArthurZucker opened this issue 9 months ago • 7 comments

What does this PR do?

Draft to win more test time

ArthurZucker avatar May 06 '24 12:05 ArthurZucker

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

HuggingFaceDocBuilderDev avatar May 06 '24 13:05 HuggingFaceDocBuilderDev

Maybe onnx sould be kept if the fetcher does not detect that if modeling files are touched they should be run as well

ArthurZucker avatar May 06 '24 13:05 ArthurZucker

The 2 new files prepared by test fetcher should be used in .circleci/create_circleci_config.py I belive.

ydshieh avatar May 06 '24 15:05 ydshieh

yes! not over yet sorry. I realized afterwards

ArthurZucker avatar May 06 '24 16:05 ArthurZucker

I will play with it and review!

ydshieh avatar May 30 '24 13:05 ydshieh

@ArthurZucker Let me know if you have any comment based on my above review. Once we achieve some agreement, I will finalize the PR.

ydshieh avatar Jun 14 '24 08:06 ydshieh

Sorry did not have time to finish

ArthurZucker avatar Jul 09 '24 19:07 ArthurZucker

PR IS DONE!

ArthurZucker avatar Aug 30 '24 15:08 ArthurZucker