transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Added Token classification for Udop

Open nileshkokane01 opened this issue 9 months ago • 4 comments

What does this PR do?

Fixes #29800

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [x] Did you write any new necessary tests?

Who can review?

@NielsRogge

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

nileshkokane01 avatar May 06 '24 11:05 nileshkokane01

@NielsRogge , Adding to all_model_classes causes 10 errors. Any hint ? As of now I have commented UdopForTokenClassification .

nileshkokane01 avatar May 06 '24 15:05 nileshkokane01

Hi @nileshkokane01, thanks for opening a PR! Are there checkpoints available for this task-specific model? We tend to reserve these additions to situations when this is the case

amyeroberts avatar May 07 '24 11:05 amyeroberts

Guess not. Not official ones at least to my sight.

The original Issue was inspired from the example code of @NielsRogge . (https://github.com/NielsRogge/Transformers-Tutorials/blob/master/UDOP%2FFine_tune_UDOPEncoderModel_on_FUNSD_%28HuggingFace_Trainer%29.ipynb)

He may have a better idea as to why it was a "Good first issue”, or could perhaps point to an available checkpoint.

nileshkokane01 avatar May 07 '24 15:05 nileshkokane01

@nileshkokane01 OK, thanks for clarifying. I've removed the label. In this case, we won't merge in. We can leave this PR as a reference in case anyone in the community would like to see how to add it in their own code :)

amyeroberts avatar May 07 '24 17:05 amyeroberts

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jun 06 '24 08:06 github-actions[bot]