transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Remove `mps` workaround for `isin()`

Open pcuenca opened this issue 1 year ago • 3 comments

Feature request

Remove mps workaround for isin()

Motivation

#30376 introduced a workaround for isin() on mps devices, because PyTorch does not support that op yet: https://github.com/pytorch/pytorch/issues/77764#issuecomment-2067838075.

Going forward, it'd be desirable to use the much more readable isin() version. This issue is meant to track PyTorch support of isin() on mps so we can remove the workaround and simplify the code.

Your contribution

I can submit a PR when the op is eventually supported.

pcuenca avatar Apr 23 '24 13:04 pcuenca

Thanks for creating an issue @pcuenca so we can track!

amyeroberts avatar Apr 23 '24 13:04 amyeroberts

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar May 24 '24 08:05 github-actions[bot]

Add wip label to exempt from stale bot.

pcuenca avatar May 24 '24 09:05 pcuenca