transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Add `finetuned_from` property in the autogenerated model card

Open sgugger opened this issue 2 years ago • 4 comments

What does this PR do?

We already extract the info but it wasn't properly put in the metadata. This PR adds it. cc @julien-c @osanseviero for the exact name of the tag to use.

sgugger avatar Jun 27 '23 15:06 sgugger

The documentation is not available anymore as the PR was closed or merged.

HuggingFaceDocBuilderDev avatar Jun 27 '23 16:06 HuggingFaceDocBuilderDev

What did you have in mind exactly? The only text added is

"This model is a fine-tuned version of f" [{self.finetuned_from}](https://huggingface.co/{self.finetuned_from}) on "

which doesn't contain the finetuned_from tag.

sgugger avatar Jun 28 '23 16:06 sgugger

@sgugger i would rename the variable everywhere

julien-c avatar Jun 29 '23 08:06 julien-c

That's a breaking change in Transformers for cosmetic reasons only, so a big no no from my side.

sgugger avatar Jun 29 '23 12:06 sgugger

I would go ahead with this PR as-is :fire:

osanseviero avatar Jul 03 '23 13:07 osanseviero