transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Neptune fix bug init run

Open AleksanderWWW opened this issue 2 years ago • 1 comments

What does this PR do?

We realised that the init_run function embedded in the integration was accepting a deprecated kwarg run which was replaced with with_id some time ago. Without this fix there might be cases where the NeptuneCallback will not run correctly and throw an error, that the function received an unexpected argument.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

AleksanderWWW avatar Apr 18 '23 15:04 AleksanderWWW

The documentation is not available anymore as the PR was closed or merged.

@sgugger Do you know more or less when will that be released?

AleksanderWWW avatar May 12 '23 08:05 AleksanderWWW

@AleksanderWWW It was released this week in v4.29.0

amyeroberts avatar May 12 '23 10:05 amyeroberts

Ah yes, my bad. I didn't realize that I had a bug in my own tests :smile: Thank you @amyeroberts!

AleksanderWWW avatar May 12 '23 11:05 AleksanderWWW