transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Add support of backward_prefetch and forward_prefetch

Open raghavanone opened this issue 2 years ago • 4 comments
trafficstars

#21156

Adds support for backward_prefetch and forward_prefetch in trainer.

@sgugger @pacman100

raghavanone avatar Jan 21 '23 15:01 raghavanone

The documentation is not available anymore as the PR was closed or merged.

HuggingFaceDocBuilderDev avatar Jan 21 '23 15:01 HuggingFaceDocBuilderDev

@sgugger Done, But not sure why this test is failing. Any pointers on how to make this build green would help.

raghavanone avatar Jan 25 '23 13:01 raghavanone

@sgugger @pacman100 Need pointer on why this test is failing.

raghavanone avatar Jan 26 '23 05:01 raghavanone

The test is a flaky one, don't worry about it. Thanks for iterating, I just have one last comment on the deprecation warning for fsdp_min_num_params and we can merge this!

Done

raghavanone avatar Jan 26 '23 15:01 raghavanone

@sgugger @pacman100 Can we merge this PR ?

raghavanone avatar Jan 31 '23 02:01 raghavanone

?Hello @raghavanone , could you please resolve the comments above that I have unresolved as they are yet to be addressed ?

pacman100 avatar Jan 31 '23 04:01 pacman100

?Hello @raghavanone , could you please resolve the comments above that I have unresolved as they are yet to be addressed ?

Done

raghavanone avatar Jan 31 '23 07:01 raghavanone

Thank you @raghavanone for iterating and addressing the comments and for the overall contribution! 🚀

pacman100 avatar Jan 31 '23 14:01 pacman100