transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Allowing users to use the latest `tokenizers` release !

Open Narsil opened this issue 2 years ago • 2 comments

What does this PR do?

  • Allow users to use the most recent tokenizers version.
  • Should be 100% backward compatible, but there were quite large changes to the actual codebase.

Fixes # (issue)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

Narsil avatar Sep 21 '22 11:09 Narsil

You need to run make style when changing the setup.

sgugger avatar Sep 21 '22 11:09 sgugger

The documentation is not available anymore as the PR was closed or merged.

Failure seem unrelated. Yet rebasing on main to remove the failure linked to the Datasets release and re-laucnhing spurious tests would be helpful to ease everyone's mind :-)

sgugger avatar Sep 21 '22 13:09 sgugger

@sgugger Should I wait for a second core maintainer's opinion on this ?

Narsil avatar Sep 21 '22 15:09 Narsil

Nope, you can go ahead and merge :-)

sgugger avatar Sep 21 '22 15:09 sgugger

I couldn't immediately find the release process for this repository - when will this make it into a release? tokenizers (for versions earlier than 0.13.0) had no wheel available for Apple silicon, so I believe until this PR is released we're stuck with source builds for that dependency.

Smaug123 avatar Sep 24 '22 21:09 Smaug123

The next release of Transformers will be in a month roughly. In the meantime, you can install it from source.

sgugger avatar Sep 26 '22 11:09 sgugger