transformers icon indicating copy to clipboard operation
transformers copied to clipboard

oneccl_bindings_for_pytorch 1.12.0 prebuilt wheel does not work with …

Open sywangyi opened this issue 2 years ago • 2 comments

…PyTorch 1.12.1

raise error in this condition and update the doc

Signed-off-by: Wang, Yi A [email protected]

Fixes # (issue) torch 1.12.1 does not work with intel ccl 1.12.0

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

@sgugger

sywangyi avatar Sep 21 '22 03:09 sywangyi

@yao-matrix @sgugger please notice the issue and help review

sywangyi avatar Sep 21 '22 03:09 sywangyi

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sgugger I agree with your point, so I upload another PR (https://github.com/huggingface/transformers/pull/19151) to only update the doc.

sywangyi avatar Sep 22 '22 03:09 sywangyi

we will release a new oneCCL 1.12.1 to work with torch 1.12.1

sywangyi avatar Sep 22 '22 06:09 sywangyi