HfArgumentParser support yaml parser

[jiangwangyi]

Feature request

HfArgumentParser now supports for parsing dict and json files, will it be possible to support for parsing the widely used yaml files?

Motivation

I think using yaml is a good way to record arguments.

Your contribution

Not yet.

[LysandreJik]

cc @sgugger

If you want to open a PR, please go ahead!

[felix-schneider]

You can just use parser.parse_dict(yaml.safe_load(f))

[sgugger]

Which could all go in a parse_yaml_file method :-) Doing this and also refactoring the parse_json_file to use parse_dict, as well as adding small tests would be nice additions that shouldn't be too hard, so putting the "Good first issue" label here.

To summarize:

• [ ] adding as parse_yaml_file method to HfArgumentParser with the code above
• [ ] refactor the dupe code between parse_json_file and parse_dict similar to the code above
• [ ] add a small test of parse_yaml_file
• [ ] add a small test of parse_json_file

This could be done in a single PR or separate ones :-)

[IMvision12]

Hi, I would like to work on it

[IMvision12]

How can i write test for parse_yaml_file and parse_json_file it will require an external json and yaml file to testing

[sgugger]

No, you can create it during the test by saving some dictionary (look at the parse_dict tests) into a temporary file.

[IMvision12]

Hey, @sgugger I have written the test for parse_yaml_file and parse_json_file using tempfile is it acceptable?? Also it passes the tests.

[sgugger]

You can also use the context manager for a temp dir.

with tempfile.TemporaryDirectory() as tmp_dir:
    # Save file in tmp_dir as usual
    # do the tests

The plus for this is that it's automatically cleaned up when you exit the with block (whereas the temp file will stay until the next restart).

[IMvision12]

Okay I will change that!