transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Fix led #19019

Open ArthurZucker opened this issue 2 years ago • 2 comments

What does this PR do?

fixes #19019 by replacing the construction of the eos_mask in the SequenceClassification. Also adds a test to make sure that long sequence are properly processed

ArthurZucker avatar Sep 16 '22 11:09 ArthurZucker

The documentation is not available anymore as the PR was closed or merged.

HuggingFaceDocBuilderDev avatar Sep 16 '22 11:09 HuggingFaceDocBuilderDev

I think deleting the class would be less confusing, we discussed this with Patrick, the original paper does not use the encoder decoder model for sequence classification. WDYT @LysandreJik

ArthurZucker avatar Sep 16 '22 21:09 ArthurZucker

Let's please do a deprecation cycle :pray:

LysandreJik avatar Sep 23 '22 18:09 LysandreJik

Would love to learn about, what can I do?

ArthurZucker avatar Oct 01 '22 05:10 ArthurZucker

I think there is still work to do here?

sgugger avatar Oct 25 '22 16:10 sgugger

@ArthurZucker, instead of deleting the class, you would first start by adding a FutureWarning when it is instantiated or called, mentioning that it is deprecated and what is recommended instead. You would mention that the class will be deleted in version 5, and that such a code will error out then.

LysandreJik avatar Oct 27 '22 16:10 LysandreJik

Oh it ! Thanks for the pointers

ArthurZucker avatar Nov 03 '22 05:11 ArthurZucker