transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Typo in configuration

Open ariG23498 opened this issue 1 year ago • 2 comments

Hey @NielsRogge

I found an inconsistency in the documentation and the code for configuration of GroupViT. The default for num_output_groups is [64, 8, 8] (notice the last element in the list), while that documented is [64, 8, 0]. It would be great if we could make the two consistent.

https://github.com/huggingface/transformers/blob/8cb5ecd912e09301be126c6ce6e9a22ca7153da4/src/transformers/models/groupvit/configuration_groupvit.py#L158

https://github.com/huggingface/transformers/blob/8cb5ecd912e09301be126c6ce6e9a22ca7153da4/src/transformers/models/groupvit/configuration_groupvit.py#L204

ariG23498 avatar Aug 09 '22 11:08 ariG23498

Hi,

thanks for spotting, feel free to fix it in #18020

NielsRogge avatar Aug 09 '22 11:08 NielsRogge

Will do!

ariG23498 avatar Aug 09 '22 11:08 ariG23498

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 08 '22 15:09 github-actions[bot]