torchMoji icon indicating copy to clipboard operation
torchMoji copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Housekeeping - upgrade to Torch 1.3.1

Open cbowdon opened this issue 5 years ago • 4 comments

Thanks for open-sourcing this work!

I'm afraid I couldn't get the dependencies to resolve without conflicts when following the README instructions, so this PR upgrades the dependency.

Since the README suggested installing PyTorch with Conda originally, I've included an environment.yml that will hopefully make this easier for future users.

To verify the changes I've run:

  • nosetests -v -a '!slow'
  • examples/text_emojize.py
  • examples/finetune_youtube_last.py

These all work as expected, although I can't guarantee this fixes every incompatibility.

cbowdon avatar Dec 30 '19 17:12 cbowdon

@cbowdon This PR was helpful, thanks! I recommend that it be merged in.

lukereichold avatar Feb 12 '20 00:02 lukereichold

Thanks for your work on this, @cbowdon!

Would be great if this could be merged in.

setu4993 avatar Feb 27 '20 05:02 setu4993

@thomwolf: Thanks for porting this from the source Keras implementation, and your continuing work with HuggingFace (big fan of transformers and tokenizers 👏 )! When you have a chance, can you please review this?

setu4993 avatar Mar 03 '20 04:03 setu4993

Hi! Thank you for your work on Torchmoji! Why hasn't this branch been merged? It's too bad to be stuck with torch 1.0.1

hugueslysfluidity avatar Mar 16 '21 15:03 hugueslysfluidity