tokenizers icon indicating copy to clipboard operation
tokenizers copied to clipboard

feat(ci): add macos arm64 runner

Open McPatate opened this issue 3 years ago • 5 comments

I've added an arm64 runner that you can check out in the settings tab.

Edited the CI to make it release arm64 bins !

McPatate avatar Jul 26 '22 08:07 McPatate

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Do you mind creating an actions where this actually ran to check what actually happened.

Just comment out the upload to pypi part, so we can iterate on it.

Narsil avatar Jul 26 '22 13:07 Narsil

Arm64 node build can be ignored. If you can just remove it from the automated build that'd be ok :)

We need to rewrite the node bindings at some point anyway (but seems like a lot of efforts :( )

Narsil avatar Jul 26 '22 14:07 Narsil

We need to rewrite the node bindings at some point anyway (but seems like a lot of efforts :( )

Does anyone use them ?

McPatate avatar Jul 26 '22 14:07 McPatate

Does anyone use them ?

There are some issues open yes, but as we're lagging behind in node versions it's harder and harder to use them https://github.com/huggingface/tokenizers/issues?q=is%3Aissue+is%3Aopen+node

Narsil avatar Jul 26 '22 14:07 Narsil

Let's close in favor of https://github.com/huggingface/tokenizers/pull/1055 if you're OK with it.

Narsil avatar Aug 25 '22 08:08 Narsil