text-embeddings-inference icon indicating copy to clipboard operation
text-embeddings-inference copied to clipboard

Implement MPNet model

Open kozistr opened this issue 1 year ago • 6 comments

What does this PR do?

Fixes #250 Fixes #33

feedback or contributions are welcome!

  • [x] inference result
    • [x] CPU
    • [x] GPU (colab T4)
    • [x] Metal
  • [x] MPNetAttentionBias
  • [x] MPNetAttention is now identical to the Python implementation.
    • [x] attention_bias
    • [x] attention_mask

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [x] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

kozistr avatar Jul 28 '24 17:07 kozistr