text-embeddings-inference icon indicating copy to clipboard operation
text-embeddings-inference copied to clipboard

Fix to allow health check w/o auth

Open kozistr opened this issue 1 year ago • 0 comments

What does this PR do?

Fixes #353

  • Separate the routers into two groups (one that requires auth and one that doesn't), and apply the auth middleware only for the group.

as-is (1.5.0)

$ curl -Is http://127.0.0.1:8081/health
HTTP/1.1 401 Unauthorized
content-length: 0
date: Fri, 26 Jul 2024 16:24:33 GMT
$ curl -Is http://127.0.0.1:8081/health -H 'Authorization: Bearer asdf'
HTTP/1.1 200 OK
content-length: 0
vary: origin, access-control-request-method, access-control-request-headers
access-control-allow-origin: *
date: Fri, 26 Jul 2024 16:24:41 GMT

to-be

$ curl -Is http://127.0.0.1:8080/health
HTTP/1.1 200 OK
content-length: 0
vary: origin, access-control-request-method, access-control-request-headers
access-control-allow-origin: *
date: Fri, 26 Jul 2024 16:24:52 GMT

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

kozistr avatar Jul 26 '24 16:07 kozistr