setfit icon indicating copy to clipboard operation
setfit copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Renamed `evaluation_strategy` to `eval_strategy`

Open sergiopaniego opened this issue 1 year ago • 1 comments

Fixes #512 and #535

Following the deprecation of evaluation_strategy to eval_strategy: Hugging Face Transformers PR #30190.

Already covered in other repos:

  • trl: https://github.com/huggingface/trl/pull/1771
  • peft: https://github.com/huggingface/peft/pull/1664

sergiopaniego avatar Jul 03 '24 14:07 sergiopaniego

@tomaarsen :smile:

sergiopaniego avatar Jul 03 '24 14:07 sergiopaniego

@tomaarsen

CalinLucian avatar Sep 10 '24 14:09 CalinLucian

Apologies for the delay! I've merged these changes into main and resolved the remaining outstanding issues as well. I expect this'll all be included in a release quite soon (this week?). Thanks a bunch for making this PR!

  • Tom Aarsen

tomaarsen avatar Sep 17 '24 15:09 tomaarsen