setfit icon indicating copy to clipboard operation
setfit copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Fix bug where SetFitHead not moved to non-cuda devices on init

Open ajmssc opened this issue 1 year ago • 6 comments

On my M2 macbook the SetFitHead is not moved to mps on init. This is because of a typo in the ternary operation to determine the GPU.

ajmssc avatar May 01 '24 17:05 ajmssc

@tomaarsen

ajmssc avatar May 03 '24 22:05 ajmssc

cc @pcuenca as well

osanseviero avatar May 09 '24 15:05 osanseviero

@pcuenca you're gonna have to do the merging because I don't have that option

ajmssc avatar May 10 '24 17:05 ajmssc

~~@ajmssc I know! I wanted to wait a few hours in case @tomaarsen wanted to comment, merging now :)~~

lol, actually I can't do it either (or run the workflow), so let's wait for a maintainer.

pcuenca avatar May 10 '24 17:05 pcuenca

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

HuggingFaceDocBuilderDev avatar May 10 '24 17:05 HuggingFaceDocBuilderDev

@tomaarsen @pcuenca what do you want to do with this PR?

ajmssc avatar May 28 '24 17:05 ajmssc

Hello!

Big apologies for the long delay - I should have gotten to this PR much sooner. Well spotted, and the fix looks solid as well. I'll merge it in a minute & include it in an upcoming release.

  • Tom Aarsen

tomaarsen avatar Sep 18 '24 10:09 tomaarsen