quanto
quanto copied to clipboard
feat: add HIP support
What does this PR do?
Fixes # (issue)
GEMM and GEMV kernels can't be compiled for AMD HIP. This PR adds a check for HIP and uses unpack kernel for HIP.
Before submitting
- [*] Did you read the contributor guideline, Pull Request section?
- [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
- [ ] Did you run all tests locally and make sure they pass.
- [ ] Did you write any new necessary tests?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Thank you for this pull-request. This looks good to me, but can you just:
- rebase your branch,
- amend you commit message to use the conventional commit convention: something like "feat: add HIP support"
FYI, if you commit is not conventional, the CI will not run any tests.
Done.
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR was closed because it has been stalled for 5 days with no activity.
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.
Rebased in #330