quanto icon indicating copy to clipboard operation
quanto copied to clipboard

feat: add HIP support

Open Disty0 opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes # (issue)

GEMM and GEMV kernels can't be compiled for AMD HIP. This PR adds a check for HIP and uses unpack kernel for HIP.

Before submitting

  • [*] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you run all tests locally and make sure they pass.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

Disty0 avatar Aug 13 '24 20:08 Disty0

Thank you for this pull-request. This looks good to me, but can you just:

  • rebase your branch,
  • amend you commit message to use the conventional commit convention: something like "feat: add HIP support"

dacorvo avatar Aug 14 '24 16:08 dacorvo

FYI, if you commit is not conventional, the CI will not run any tests.

dacorvo avatar Aug 14 '24 16:08 dacorvo

Done.

Disty0 avatar Aug 14 '24 20:08 Disty0

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 31 '24 01:08 github-actions[bot]

This PR was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Sep 05 '24 01:09 github-actions[bot]

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 03 '24 02:10 github-actions[bot]

Rebased in #330

dacorvo avatar Oct 04 '24 16:10 dacorvo