quanto icon indicating copy to clipboard operation
quanto copied to clipboard

Switch to ruff native formatter

Open dacorvo opened this issue 10 months ago • 10 comments

Ruff is faster than black and produces nearly identical results.

The goal of this issue is to switch to ruff for the style check and formatting.

dacorvo avatar Apr 22 '24 07:04 dacorvo

By switching to ruff for style check and formatting, do you mean removing black? It looks like both black and ruff run to do style check in workflows and as in the instructions for contributing, running make style formats with both packages.

aryanmagoon avatar Apr 26 '24 15:04 aryanmagoon

Yes, it means removing black and use only ruff.

dacorvo avatar Apr 29 '24 07:04 dacorvo

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 30 '24 01:05 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 30 '24 01:06 github-actions[bot]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 01 '24 01:08 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Aug 07 '24 01:08 github-actions[bot]

Yes, it means removing black and use only ruff.

Dear optimum-quanto maintainers, I saw black is still in the setup.sh and pyproject.toml, are we still considering switching?

davidgao7 avatar Aug 08 '24 03:08 davidgao7

Yes, it means removing black and use only ruff.

Dear optimum-quanto maintainers, I saw black is still in the setup.sh and pyproject.toml, are we still considering switching?

Yes, this is still planned, but no pull-request has been submitted yet.

dacorvo avatar Aug 26 '24 07:08 dacorvo

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 26 '24 02:09 github-actions[bot]

@dacorvo Submitted a pull request for this, please review and let me know. Thanks.

ishandeva avatar Oct 06 '24 16:10 ishandeva