switch setup.py to pyproject.toml

[baggiponte]

Ciao! Great job with quanto, can't wait to play with it. Would like to propose to switch the project config to pyproject.toml completely: it's the new standard for python packaging and I already implemented that for HF datatrove here. There are some references on why it might be optimal to make the switch here.

[dacorvo]

@baggiponte thank you for your feedback. As you can see in the commit below, the only reason there is a setup.py is because of an issue when parsing metadata using setuptools:

https://github.com/huggingface/quanto/commit/b9757456fb5a90302fd0740511a05ff6369b8f17

[baggiponte]

Thanks for the reply! The metadata that was not properly parsed was the URLs? It did not display properly on PyPI?

[dacorvo]

Yes (the previous commit). (Completely off-topic, but I have the exact same desk as yours: ikea ?).

[baggiponte]

Ciao @dacorvo, sorry for the late reply. I opened a draft PR to provide a possible solution and see if you could reproduce the bug you mention about the commit with this setup.

(What a keen eye! That was my previous employer and I never asked. Though I am looking for one now!)

[github-actions[bot]]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 5 days with no activity.