peft icon indicating copy to clipboard operation
peft copied to clipboard

LoftQ init without scaling

Open cobbswordsman opened this issue 1 year ago • 3 comments

https://github.com/huggingface/peft/blob/f13d860e9f58e908ac85e78ac37528ec8c84eb99/src/peft/tuners/lora/layer.py#L226

I find scaling with pissa and dora,but no scaling with loftq init Lora_A and lora_B. It's a bug?or no need to do that

cobbswordsman avatar Jul 31 '24 09:07 cobbswordsman

I agree, it looks like it could make sense to consider the scaling factor when applying LoftQ. @fxmeng could you comment on that?

BenjaminBossan avatar Jul 31 '24 09:07 BenjaminBossan

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

github-actions[bot] avatar Sep 11 '24 15:09 github-actions[bot]

Gentle ping again @fxmeng

BenjaminBossan avatar Sep 11 '24 15:09 BenjaminBossan

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

github-actions[bot] avatar Oct 06 '24 15:10 github-actions[bot]

Another ping @fxmeng.

BenjaminBossan avatar Oct 07 '24 10:10 BenjaminBossan

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

github-actions[bot] avatar Oct 31 '24 15:10 github-actions[bot]