peft
peft copied to clipboard
huggingface
Apply deprecated `evaluation_strategy`
This PR applies the deprecated evaluation_strategy from https://github.com/huggingface/transformers/pull/30190.
TL;DR: evaluation_strategy -> eval_strategy
(Should go live in v4.41.0, but opening now so it's here when ready!)
Check out this pull request on 
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
![review-notebook-app[bot] avatar](https://avatars.githubusercontent.com/in/15474?v=4 "Published by a pub.dev verified publisher"){kind=small}
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
Hmm, but this means that any older transformers version would result in an error, would it not? If we merge this PR, everyone trying to use those examples needs to upgrade to the latest transformers just to avoid getting a deprecation message. I think this is not worthwhile.
Ideally, we can revisit this PR in 6-12 months, when we can be reasonably sure that most users have moved to a new transformers version, or once transformers v4.46 is slated to be released.
@BenjaminBossan will go live in v4.41.0 and stay until 4.46.0 as detailed in the thread (6 months)
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'm still withholding review to wait for
will go live in v4.41.0 and stay until 4.46.0 as detailed in the thread (6 months)
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.