optimum icon indicating copy to clipboard operation
optimum copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Add support for siglip models

Open xenova opened this issue 1 year ago • 7 comments

What does this PR do?

This PR adds support for exporting SigLIP models to ONNX. WIP for this issue.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you make sure to update the documentation with your changes?
  • [x] Did you write any new necessary tests?

xenova avatar Dec 04 '23 21:12 xenova

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

HuggingFaceDocBuilderDev avatar Dec 04 '23 22:12 HuggingFaceDocBuilderDev

Got it working 🥳 https://github.com/xenova/transformers.js/pull/473

xenova avatar Dec 24 '23 00:12 xenova

https://github.com/huggingface/transformers/pull/26522 Is now merged into transformers!

xenova avatar Jan 11 '24 16:01 xenova

@xenova can you push to this branch so that the CI is rerun?

fxmarty avatar Jan 26 '24 08:01 fxmarty

Done ✅ (merged main)

xenova avatar Jan 26 '24 10:01 xenova

Thanks! Not sure why we have

=========================== short test summary info ============================
FAILED exporters/onnx/test_onnx_export.py::OnnxExportTestCase::test_all_models_tested - AssertionError: Not testing all models. Missing models: {'siglip-text-with-projection', 'siglip-text-model'}

fxmarty avatar Jan 26 '24 10:01 fxmarty

Hey @xenova, any status on this? Can we get it merged? :)

I feel that this model is highly relevant and needs optimized inference :)

Benjoyo avatar Apr 28 '24 21:04 Benjoyo