lerobot icon indicating copy to clipboard operation
lerobot copied to clipboard

record resume error: no reset time

Open IlIllllll opened this issue 1 year ago • 1 comments

System Info

- `lerobot` version: 0.1.0
- Platform: Linux-5.15.0-125-generic-x86_64-with-glibc2.31
- Python version: 3.10.15
- Huggingface_hub version: 0.26.3
- Dataset version: 3.1.0
- Numpy version: 1.26.4
- PyTorch version (GPU?): 2.5.1+cu124 (True)
- Cuda version: 12040
- Using GPU in script?: yes

Information

  • [X] One of the scripts in the examples/ folder of LeRobot
  • [ ] My own task or dataset (give details below)

Reproduction

When using the resume parameter, the reset time is skipped when the number of episodes that have been recorded in the dataset is greater than the total number, in this code(control_robot.py 305)

        if not events["stop_recording"] and (
            (dataset.num_episodes < num_episodes - 1) or events["rerecord_episode"]
        ):
            log_say("Reset the environment", play_sounds)
            reset_environment(robot, events, reset_time_s)

because the inital is set as no episodes recorded , in control_robot.py 275

recorded_episodes = 0

Expected behavior

just change recorded_episodes = dataset.num_episodes, and it does no change to normal record

IlIllllll avatar Dec 09 '24 07:12 IlIllllll

thanks, i didn't even realized it

Vacuame avatar Dec 25 '24 12:12 Vacuame

This issue has been automatically marked as stale because it has not had recent activity (6 months). It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 05 '25 02:10 github-actions[bot]