lerobot icon indicating copy to clipboard operation
lerobot copied to clipboard

Dependencies: exclude `datasets` and `huggingface_hub` major version updates

Open lhoestq opened this issue 9 months ago • 3 comments

e.g. for when datasets will implement VideoFrame

lhoestq avatar May 10 '24 09:05 lhoestq

Related discussion on the discord (TLDR: having upper bounds on dependencies has generally more drawbacks than benefits)

I'm okay for having an upper bound on datasets' major version, but I'd rather keep it as it is for the hub as "^0.X.Y" actually translates into ">=0.X.Y, <0.X+1.0", which is a bit too restrictive I think. Unless breaking changes are coming on the minor?

aliberts avatar May 10 '24 15:05 aliberts

as you prefer, just take into account that breaking changes might happen in major versions (not sure what kind for hfh, but for datasets it may include the VideoFrame type for example)

lhoestq avatar May 10 '24 15:05 lhoestq

Let's keep the hub dependency as it is for now. I've push a fix which you can rebase from on branch user/aliberts/2024_05_10_patch_hf_hub

aliberts avatar May 10 '24 15:05 aliberts