huggingface_hub icon indicating copy to clipboard operation
huggingface_hub copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Fix Error messages

Open philschmid opened this issue 1 year ago • 3 comments

This PR fixes the validator for top_p, which should be allows to be set to 1.0.

philschmid avatar Jan 11 '24 14:01 philschmid

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

HuggingFaceDocBuilderDev avatar Jan 11 '24 14:01 HuggingFaceDocBuilderDev

1.0 is not a valid value. top_p must be > 0.0 and < 1.0.

OlivierDehaene avatar Jan 22 '24 09:01 OlivierDehaene

1.0 is not a valid value. top_p must be > 0.0 and < 1.0.

doesn't transformers support 1.0?

philschmid avatar Jan 22 '24 09:01 philschmid

Since https://github.com/huggingface/huggingface_hub/pull/2094 there is no client-side validation (no pydantic) to avoid this kind of situation where we can't know before-hand which values the server is able to handle. I'm therefore closing this PR without merging.

Wauplin avatar Mar 20 '24 15:03 Wauplin