diffusion-models-class icon indicating copy to clipboard operation
diffusion-models-class copied to clipboard

Might be a typo on formula for diffusion step using alpha

Open hangjoni opened this issue 2 years ago • 4 comments

On the formula for q(xt | x0) on text between cell 9 and 10 of notebook 01_introduction_to_diffusers, currently the formula is stated as :

q(xt | x0) ~ N(sqrt(1-alpha)*x0, sqrt(1-alpha)*I)

=> This might be a typo, according to the paper it should be:

q(xt | x0) ~ N(sqrt(1-alpha)*x0, (1-alpha)*I)

Sorry for the bad typing

hangjoni avatar Dec 01 '22 14:12 hangjoni

I believe the typo may be in the paper! Elsewhere (eg in the derivation in this video there is a square root there.

johnowhitaker avatar Dec 02 '22 04:12 johnowhitaker

@hangjoni @johnowhitaker actually it's the same thing : image

Source:Understanding Diffusion Models: A Unified Perspective by calvin luo(Page-11)

akshatvishu avatar Dec 02 '22 14:12 akshatvishu

Ah right, got my notation mixed and was confused between variance and standard deviation. I'll tweak the notebook to correct and add a better explanation, and see if I've propagated my incorrect version anywhere else!

johnowhitaker avatar Dec 02 '22 15:12 johnowhitaker

Thank you for explaining!

hangjoni avatar Dec 02 '22 15:12 hangjoni

Fixed

johnowhitaker avatar Dec 05 '22 06:12 johnowhitaker