diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Implement `add_noise` in iPNDMScheduler

Open pcuenca opened this issue 3 years ago • 1 comments

This method is missing from the recently-added IPNDMScheduler. It's not required for inference, but I think we should add it for consistency with all the others.

TODO:

  • [ ] revert 56210ad when this is done.

pcuenca avatar Oct 26 '22 09:10 pcuenca

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Nov 25 '22 15:11 github-actions[bot]

Honestly don't think it's that important iPNDMScheduler is only used for dance diffusion which is not heavily used.

IMO the "for consistency" argument is a dangerous one that might slow us down too much.

patrickvonplaten avatar Nov 30 '22 11:11 patrickvonplaten

I agree, let's wait until we really need it. I just added this issue because a test failed, will remove the comment instead.

pcuenca avatar Nov 30 '22 13:11 pcuenca