diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Ptxla updates

Open entrpn opened this issue 1 year ago • 4 comments

What does this PR do?

Fixes step time calculations for ptxla training script.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [X] Did you read the contributor guideline?
  • [X] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [X] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

entrpn avatar Sep 16 '24 21:09 entrpn

@sayakpaul please help me review. I fixed the per step time calculations which were wrong previously. Thanks!

entrpn avatar Sep 17 '24 02:09 entrpn

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Oct 17 '24 15:10 github-actions[bot]

@sayakpaul I'm still working on this.

entrpn avatar Oct 17 '24 17:10 entrpn

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.