diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[Tests] Fix CI for deprecated attention block when used with `device_map`

Open sayakpaul opened this issue 1 year ago • 1 comments

What does this PR do?

Ran a round of fast GPU tests (from push_tests.yml). They are all passing except for the deprecated attention block.

I think the change is okay because it doesn't introduce any performance regressions in the CI, either.

The failure: https://github.com/huggingface/diffusers/actions/runs/10734214122/job/29768965396#step:6:4275

sayakpaul avatar Sep 16 '24 08:09 sayakpaul

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Oct 20 '24 15:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Nov 17 '24 15:11 github-actions[bot]

cc @DN6 is this ok to merge?

yiyixuxu avatar Nov 17 '24 16:11 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Dec 12 '24 15:12 github-actions[bot]

@DN6 okay to merge?

sayakpaul avatar Dec 13 '24 06:12 sayakpaul

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 16 '25 15:01 github-actions[bot]

@DN6 okay to merge?

sayakpaul avatar Feb 19 '25 05:02 sayakpaul

Sorry missed this. Yes can merge. Failing tests are unrelated.

DN6 avatar Feb 20 '25 15:02 DN6

Oh wait this was already fixed with this? https://github.com/huggingface/diffusers/blob/a4c1aac3ae10172f4acb8eaf83aac7f1f6e02ab0/tests/models/test_attention_processor.py#L88

PR: https://github.com/huggingface/diffusers/pull/10359

DN6 avatar Feb 20 '25 15:02 DN6

You're right

sayakpaul avatar Feb 20 '25 16:02 sayakpaul