diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

consistency in argument names

Open christopher5106 opened this issue 1 year ago • 1 comments

Describe the bug

tokens should be token for consistency with load method: https://huggingface.co/docs/diffusers/en/api/loaders/textual_inversion#diffusers.loaders.TextualInversionLoaderMixin.unload_textual_inversion

Load method https://huggingface.co/docs/diffusers/en/api/loaders/textual_inversion#diffusers.loaders.TextualInversionLoaderMixin.load_textual_inversion uses single argument token=

Reproduction

Logs

No response

System Info

Who can help?

No response

christopher5106 avatar Jul 31 '24 11:07 christopher5106

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Nov 14 '24 15:11 github-actions[bot]

Since the argument name cannot be changed at the moment for backwards compatibility, it is better to update the docs. Maybe I could flag this for 1.0.0 refactor where making breaking changes like this would be okay. I do think using tokens as the argument name in all occurrences would be better.

a-r-r-o-w avatar Nov 18 '24 17:11 a-r-r-o-w

Closing because fixed for now in #9940

a-r-r-o-w avatar Nov 18 '24 17:11 a-r-r-o-w