[add pipeline]: A new Pixart-based inpainting pipeline.
We add a pixart model-based inpaint method that works similarly to pipeline_stable_diffusion_inpaint. @sayakpaul @yiyixuxu @DN6
Could we see some results here to decide if it's worth adding as a core pipeline?
Cc: @lawrence-cj
cc @asomoza here too!
Could we see some results here to decide if it's worth adding as a core pipeline?
Cc: @lawrence-cj
prompt='Face of a yellow cat, high resolution, sitting on a park bench'
prompt=''
This is an image of the effects of a different prompt, which the pipeline has merged with the official PixArt repository.@sayakpaul @yiyixuxu @DN6 @lawrence-cj
@lawrence-cj could you review this too?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
@eightmusic let's get the comments resolved and we would be happy to include in the new release we're cooking.
@eightmusic let's get the comments resolved and we would be happy to include in the new release we're cooking. ruff check examples scripts src tests utils benchmarks setup.py src/diffusers/pipelines/pixart_alpha/pipeline_pixart_inpaint.py:15:1: I001 [] Import block is un-sorted or un-formatted src/diffusers/pipelines/pixart_alpha/pipeline_pixart_inpaint.py:23:31: F401 []
torch.nn.functionalimported but unused src/diffusers/pipelines/pixart_alpha/pipeline_pixart_inpaint.py:454:1: W293 [] Blank line contains whitespace src/diffusers/pipelines/pixart_alpha/pipeline_pixart_inpaint.py:509:1: W293 [] Blank line contains whitespace src/diffusers/pipelines/pixart_alpha/pipeline_pixart_inpaint.py:1092:49: W292 [] No newline at end of file Found 5 errors. [] 5 fixable with the--fixoption. make: *** [Makefile:43: quality] Error 1 These problems have been solved.@sayakpaul
Thank you!
There are still open comments left to be addressed. Additionally, we need to have docs and tests for this to get merged.
Thank you!
There are still open comments left to be addressed. Additionally, we need to have docs and tests for this to get merged.
The previous comments should be resolved, is there anything else I need to do?
Well, the tests are failing. We need to get them sorted. And then there are comments still open, e.g.: https://github.com/huggingface/diffusers/pull/7929#pullrequestreview-2066566910, https://github.com/huggingface/diffusers/pull/7929#discussion_r1604487436.
And then we need to add tests for the pipeline and documentation. LMK if there's anything unclear.
https://github.com/huggingface/diffusers/pull/7929#pullrequestreview-2066566910, https://github.com/huggingface/diffusers/pull/7929#discussion_r1604487436.This problem has just been solved.'We need to get them sorted.' What do I need to do here. Are there any references to test and docs? I don't know what this is.@sayakpaul
Are there any references to test and docs?
- Here's how an inpainting test suite should be devised: https://github.com/huggingface/diffusers/blob/main/tests/pipelines/stable_diffusion_2/test_stable_diffusion_inpaint.py.
- Here's how a pipeline doc should be added: https://github.com/huggingface/diffusers/blob/main/docs/source/en/api/pipelines/pixart.md.
Quality tests can be fixed by running make style && make quality. Refer to the contribution guidelines for more details.
Sry to disturb you, but I found I can't push a commit to this branch, any suggestions? @sayakpaul
I think you will need for submit a PR to https://github.com/eightmusic/diffusers/. Perhaps @eightmusic could add you as a collaborator to the repo?
Agree. I can help adding the make style and test part. Is it possible to add me as a collaborator to your forked diffusers repo? @eightmusic
Agree. I can help adding the make style and test part. Is it possible to add me as a collaborator to your forked diffusers repo? @eightmusic
of course.
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.
Please note that issues that do not follow the contributing guidelines are likely to be ignored.