diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[Model Card] standardize advanced diffusion training sdxl lora

Open chiral-carbon opened this issue 10 months ago • 14 comments

What does this PR do?

Fixes #6891 for Advanced Diffusion Training SDXL with LoRA

Notebook example: Jupyter notebook Example model card: Model Card

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline?
  • [x] Did you read our philosophy doc (important for complex PRs)?
  • [x] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

@sayakpaul @linoytsaban

chiral-carbon avatar Apr 09 '24 07:04 chiral-carbon

thanks @linoytsaban! have addressed the use_dora check, please review!

chiral-carbon avatar Apr 17 '24 01:04 chiral-carbon

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hey @chiral-carbon! I think once we address the "lora" -> lora change it'll also pass all the tests and we can merge :)

linoytsaban avatar May 28 '24 07:05 linoytsaban

Hi @linoytsaban my apologies, I completely missed this message, will do it asap!

chiral-carbon avatar Jun 06 '24 20:06 chiral-carbon

@linoytsaban pushed it!

chiral-carbon avatar Jun 10 '24 18:06 chiral-carbon

Thanks @chiral-carbon! I'm not sure what's failing the quality tests now 🧐 could you run make fix up please?

linoytsaban avatar Jun 11 '24 06:06 linoytsaban

hi @linoytsaban this is the output of make fixup:

(hf-diff) ada@Abhipshas-MacBook-Pro diffusers % make fixup
Checking/fixing examples/advanced_diffusion_training/train_dreambooth_lora_sd15_advanced.py
Found 3 errors (3 fixed, 0 remaining).
1 file reformatted
python utils/custom_init_isort.py
python utils/check_doc_toc.py --fix_and_overwrite
running deps_table_update
updating src/diffusers/dependency_versions_table.py
python utils/check_dummies.py
python utils/check_repo.py
Traceback (most recent call last):
  File "/Users/ada/Desktop/Projects/diffusers/utils/check_repo.py", line 25, in <module>
    from diffusers.models.auto import get_values
ModuleNotFoundError: No module named 'diffusers.models.auto'
make: *** [repo-consistency] Error 1

it seems that it has no module named models.auto?

chiral-carbon avatar Jun 11 '24 15:06 chiral-carbon

Could you run make style && make quality?

tolgacangoz avatar Jun 11 '24 16:06 tolgacangoz

this is the output of make style && make quality:

(hf-diff) ada@Abhipshas-MacBook-Pro diffusers % make style && make quality
ruff check examples scripts src tests utils benchmarks setup.py --fix
ruff format examples scripts src tests utils benchmarks setup.py
1 file reformatted, 874 files left unchanged
doc-builder style src/diffusers docs/source --max_len 119
/Library/Developer/CommandLineTools/usr/bin/make autogenerate_code
running deps_table_update
updating src/diffusers/dependency_versions_table.py
/Library/Developer/CommandLineTools/usr/bin/make extra_style_checks
python utils/custom_init_isort.py
python utils/check_doc_toc.py --fix_and_overwrite
ruff check examples scripts src tests utils benchmarks setup.py
ruff format --check examples scripts src tests utils benchmarks setup.py
875 files left unchanged
doc-builder style src/diffusers docs/source --max_len 119 --check_only
python utils/check_doc_toc.py

have pushed it as well, it changed the formatting of the widget_dict append operation in line 124

chiral-carbon avatar Jun 12 '24 19:06 chiral-carbon

should I also run make test? the contributor guidelines said that it would take time to run normally so I skipped it

chiral-carbon avatar Jun 12 '24 19:06 chiral-carbon

hi @linoytsaban @tolgacangoz! is this PR good to be merged?

chiral-carbon avatar Jul 11 '24 00:07 chiral-carbon

It seems that there are conflicts that must be resolved. Could you resolve them?

tolgacangoz avatar Jul 14 '24 07:07 tolgacangoz

@tolgacangoz done

chiral-carbon avatar Jul 15 '24 08:07 chiral-carbon

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]