diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Check for latents, before calling prepare_latents - sdxlImg2Img

Open nileshkokane01 opened this issue 10 months ago • 7 comments

What does this PR do?

Fixes #7011

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline?
  • [x] Did you read our philosophy doc (important for complex PRs)?
  • [x] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

@sayakpaul @yiyixuxu

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

nileshkokane01 avatar Apr 05 '24 06:04 nileshkokane01

should we make this consistent for all img2img pipeline then? cc @sayakpaul

yiyixuxu avatar Apr 08 '24 18:04 yiyixuxu

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Perhaps, as all suffer the same thing! Let me know, I'll modify it for all img2img pipelines.

nileshkokane01 avatar Apr 09 '24 00:04 nileshkokane01

should we make this consistent for all img2img pipeline then?

Yeah works for me.

sayakpaul avatar Apr 09 '24 01:04 sayakpaul

@yiyixuxu , can you have a look or list some files that I missed to update?

nileshkokane01 avatar Apr 15 '24 05:04 nileshkokane01

@nileshkokane01 can you look into the test failure? seem relevant here

yiyixuxu avatar Apr 19 '24 08:04 yiyixuxu

@yiyixuxu can you please check now ?
BTW, why aren't the test running automatically as we push the changes , as it happens for the transformers library?

nileshkokane01 avatar Apr 28 '24 05:04 nileshkokane01

thank you:) @nileshkokane01

yiyixuxu avatar Apr 29 '24 00:04 yiyixuxu