diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Set main_input_name in StableDiffusionSafetyChecker to "clip_input"

Open clinty opened this issue 1 year ago • 5 comments

FlaxStableDiffusionSafetyChecker sets main_input_name to "clip_input". This makes StableDiffusionSafetyChecker consistent.

clinty avatar Mar 27 '24 21:03 clinty

Hi @clinty! Thanks for the contribution. However, I'd like to understand what purpose it serves or how you expect this to be used. Unlike in the transformers codebase, main_input_name is not used in diffusers (except for some tests). Are you experiencing any shortcomings because it's not defined in StableDiffusionSafetyChecker?

pcuenca avatar Mar 28 '24 08:03 pcuenca

@pcuenca only confusion on my part when I checked the value and found it to be input_ids and not one of the two valid inputs. I am not aware of any code which is using this.

clinty avatar Mar 28 '24 12:03 clinty

Ah, it's set to a default value. In that case I'd support changing it to avoid confusion. I triggered a CI run, copying @sayakpaul as this affects the PyTorch implementation

pcuenca avatar Mar 28 '24 13:03 pcuenca

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 27 '24 15:04 github-actions[bot]

The test failure has the appearance of something transient.

clinty avatar Apr 29 '24 13:04 clinty