diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Experimental feature to use tokens not in <s\d> format

Open NorilskMajor opened this issue 11 months ago • 11 comments

Create a new flag that will incorporate provided tokens abstraction into model tokens to prevent multiple LoRAs clashing.

What does this PR do?

Creates an experimental flag that will rename the default to <TOK_0><TOK_1>.

Fixes #7298

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline?
  • [x] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

NorilskMajor avatar Mar 13 '24 04:03 NorilskMajor

@sayakpaul

NorilskMajor avatar Mar 13 '24 04:03 NorilskMajor

@NorilskMajor thanks a lot for the PR! I think it'll be great to have better support for multiple loras as you described in https://github.com/huggingface/diffusers/issues/7298

linoytsaban avatar Mar 13 '24 19:03 linoytsaban

@linoytsaban feel free to give the PR a review and let us know!

sayakpaul avatar Mar 15 '24 06:03 sayakpaul

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@linoytsaban a gentle ping.

sayakpaul avatar Mar 20 '24 02:03 sayakpaul

Hey @NorilskMajor! it looks like it's still failing the quality tests due to 2 lines that need to be reformatted, could you run make fixup?

linoytsaban avatar Apr 15 '24 13:04 linoytsaban

Hey @linoytsaban, image I ran the make quality however the affected 2 files are not listed. Running make fixup also doesn't affect these files. I'm not entirely sure why the presubmits fail this way.

NorilskMajor avatar Apr 15 '24 13:04 NorilskMajor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar May 09 '24 15:05 github-actions[bot]

What's pending with this PR? Cc: @linoytsaban

sayakpaul avatar Jun 29 '24 13:06 sayakpaul

@sayakpaul only the quality checks I believe, not sure why they're failing

linoytsaban avatar Jul 01 '24 10:07 linoytsaban

Possible for you to clone the PR branch and commit directly?

sayakpaul avatar Jul 01 '24 10:07 sayakpaul

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]