diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Update model card template train_text_to_image_lora_sdxl.py

Open sr5434 opened this issue 11 months ago • 8 comments

What does this PR do?

Instead of saying "LoRA for the text encoder was enabled: (true/false)", say "LoRA for the text encoder was enabled" when true.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline?
  • [x] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@sayakpaul and @patrickvonplaten

sr5434 avatar Feb 25 '24 18:02 sr5434

I am okay with this but let’s apply to all the scripts where applicable.

sayakpaul avatar Feb 25 '24 19:02 sayakpaul

Should I squash the commits when I do so?

sr5434 avatar Feb 26 '24 12:02 sr5434

I updated all availible examples(except for community and research examples)

sr5434 avatar Feb 26 '24 18:02 sr5434

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

HuggingFaceDocBuilderDev avatar Feb 27 '24 01:02 HuggingFaceDocBuilderDev

Can I revise the commit message and keep the changes for the non-lora related files?

sr5434 avatar Feb 27 '24 15:02 sr5434

Is this better?

sr5434 avatar Feb 27 '24 16:02 sr5434

@sayakpaul is this better

sr5434 avatar Mar 12 '24 11:03 sr5434

There are still unrelated changes.

We're not just focusing on

Instead of saying "LoRA for the text encoder was enabled: (true/false)", say "LoRA for the text encoder was enabled" when true.

Can we do that i.e., focus on that part and that part only in this PR?

sayakpaul avatar Mar 12 '24 11:03 sayakpaul

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 05 '24 15:04 github-actions[bot]

Closing because of inactitivites.

sayakpaul avatar Jun 30 '24 05:06 sayakpaul