diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

update

Open aihao2000 opened this issue 1 year ago • 12 comments

What does this PR do?

  • load_dataset data_dir Supports custom local datasets. Just like https://github.com/huggingface/diffusers/pull/5747#event-10922633415
  • Update fingerprint hash parameters. Avoid irrelevant parameters causing repeated calculations in the map cache

Fixes # (issue)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline?
  • [ ] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@sayakpaul and @patrickvonplaten

aihao2000 avatar Feb 23 '24 07:02 aihao2000

Thanks for your contributions! Can we please break this PR into multiple PRs as it targets multiple mutually exclusive areas?

sayakpaul avatar Feb 23 '24 07:02 sayakpaul

@sayakpaul Yes, feel free to change it.

aihao2000 avatar Feb 23 '24 09:02 aihao2000

Sorry for not being clear. I was asking you to tackle this in multiple PRs

sayakpaul avatar Feb 23 '24 09:02 sayakpaul

@sayakpaul I'm not familiar with git and it seems a little troublesome. Are there any doubtful changes? I can restore that part.

aihao2000 avatar Feb 26 '24 16:02 aihao2000

It's a general good practice to not introduce multiple changes in a single PR. And I would like to follow that. For example, for each of the points you enlisted in the PR description, you could create PRs (four PRs).

sayakpaul avatar Feb 26 '24 16:02 sayakpaul

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 24 '24 15:03 github-actions[bot]

@aihao2000 a gentle ping here

sayakpaul avatar Mar 24 '24 15:03 sayakpaul

@sayakpaul IIt is now only about the addition of the data_dir parameter. Is this okay?

aihao2000 avatar Mar 29 '24 08:03 aihao2000

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 22 '24 15:04 github-actions[bot]

@aihao2000 can we address the last comment and get this merged?

yiyixuxu avatar Apr 22 '24 18:04 yiyixuxu

@yiyixuxu Should I submit a new commit to restore this code?

aihao2000 avatar Apr 23 '24 03:04 aihao2000

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]