diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[Refactor] How attention is set in 3D UNet blocks

Open DN6 opened this issue 1 year ago • 7 comments

What does this PR do?

There's some confusion around how num_attention_heads is being used in the 3D UNet + Block. This PR attempts to fix the issue by correcting the values used for num_attention_heads

Related: https://github.com/huggingface/diffusers/pull/6872 https://github.com/huggingface/diffusers/pull/6873

Fixes # (issue)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ ] Did you read the contributor guideline?
  • [ ] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

DN6 avatar Feb 07 '24 12:02 DN6

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 09 '24 15:03 github-actions[bot]

@DN6 let's finish up this soon:)

yiyixuxu avatar Mar 09 '24 18:03 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 03 '24 15:04 github-actions[bot]

@yiyixuxu Anything specific you wanted to address in this current PR?

DN6 avatar Apr 10 '24 16:04 DN6

Oh wait. Nvm I haven't addressed those initial comments. Will wrap this up.

DN6 avatar Apr 10 '24 16:04 DN6

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar May 05 '24 15:05 github-actions[bot]