diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

MotionAdapter.from_single_file

Open eps696 opened this issue 1 year ago • 16 comments

Model/Pipeline/Scheduler description

Animatediff is a great technique with exploding interest and advancements; additional custom models start popping around in ckpt format, which cannot be loaded to diffusers in the meantime. is it possible to implement from_single_file function for motion adapter, similar to how it's done now for say controlnet?

Open source status

  • [X] The model implementation is available.
  • [X] The model weights are available (Only relevant if addition is not a scheduler).

Provide useful links for the implementation

No response

eps696 avatar Dec 20 '23 11:12 eps696

Hi @eps696 this is definitely something we can consider. We're working on a clean up of from_single_file at the moment so it might take a bit of time. Could you point me to these new checkpoints? I can see if there's a way to convert them to diffusers format as an intermediate solution.

DN6 avatar Dec 20 '23 12:12 DN6

thanks for a prompt response! here is few examples: https://github.com/Lightricks/LongAnimateDiff https://huggingface.co/guoyww/animatediff/tree/main [see v3 versions]

eps696 avatar Dec 20 '23 16:12 eps696

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 19 '24 15:01 github-actions[bot]

Agree that from_single_file method will be helpful. Since animatediff was added to diffusers, new versions for SD as well as SDXL has been released. But unable to use them, as from_single_file isn't supported and those new models are usually a single .ckpt files.

rishabhjain avatar Jan 24 '24 11:01 rishabhjain

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Feb 17 '24 15:02 github-actions[bot]

@yiyixuxu @DN6 not sure why gh bot chose to close this as stale label was removed?

vladmandic avatar Feb 26 '24 15:02 vladmandic

+1, just yesterday tried fresh release - from_single_file not implemented yet for motion adapter

eps696 avatar Feb 26 '24 15:02 eps696

ohh sorry 😱 I didn't know it does that

not sure why gh bot chose to close this as stale label was removed?

yiyixuxu avatar Feb 26 '24 19:02 yiyixuxu

Hi @eps696 have you tried using the AnimateDiff conversion scripts with those checkpoints?

https://github.com/huggingface/diffusers/blob/main/scripts/convert_animatediff_motion_module_to_diffusers.py https://github.com/huggingface/diffusers/blob/main/scripts/convert_animatediff_motion_lora_to_diffusers.py

DN6 avatar Feb 28 '24 08:02 DN6

Hi @eps696 have you tried using the AnimateDiff conversion scripts with those checkpoints?

no, missed it somehow, thanks for a hint!

eps696 avatar Feb 28 '24 19:02 eps696

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 24 '24 15:03 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 18 '24 15:04 github-actions[bot]

ping to remove stale status.

vladmandic avatar Apr 18 '24 15:04 vladmandic

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar May 13 '24 15:05 github-actions[bot]

@DN6 I think this is not supported yet with the new from_single_file - do we plan to support it? should we ask community to help?

yiyixuxu avatar May 13 '24 19:05 yiyixuxu

Yes we can 👍🏽 Was planning on adding the support this week, but definitely a good one for the community as well.

DN6 avatar May 21 '24 11:05 DN6

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]

ping to remove stale status.

vladmandic avatar Sep 14 '24 15:09 vladmandic

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Oct 09 '24 15:10 github-actions[bot]

ping to remove stale status.

vladmandic avatar Oct 09 '24 15:10 vladmandic

Hi @vladmandic we merged #8819 with single file support for MotionAdapter a little while back.

DN6 avatar Oct 15 '24 09:10 DN6

Closing since this has been completed.

DN6 avatar Oct 15 '24 09:10 DN6