diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Fix Flax flip_sin_to_cos

Open akashgokul opened this issue 2 years ago • 2 comments

Adding flip_sin_to_cos arg for FlaxTimesteps and passing it to get_sinusodial_embeddings.

Currently, FlaxTimesteps hardcodes the order of the sin and cosine embeddings (1). However, in the UNet2DConditionModel the order is an argument (set to True when loaded from StableDiffusion pretrained ckpt/config) which is currently not supported in Flax.

akashgokul avatar Nov 23 '22 03:11 akashgokul

The documentation is not available anymore as the PR was closed or merged.

thank you @akashgokul I actually had a look at this and it's good from my end! Unet is the only place where the sin/cos is flipped so that is also fine. Let me update the branch and run the tests.

kashif avatar Nov 30 '22 12:11 kashif