diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Examples contain hardcoded model names

Open allo- opened this issue 3 years ago • 5 comments

Describe the bug

Commit c18941b introduced hardcoded model names in the example scripts. Most of them should probably be replaced by args.pretrained_model_name_or_path.

Reproduction

Run one of the scripts with a model in a local folder and the commandline option --pretrained_model_name_or_path model_folder. The script nevertheless tries to download stable diffusion and either downloads an unnecessary model or fails because of a missing huggingface token.

System Info

Version: 4625f04

allo- avatar Nov 15 '22 18:11 allo-

Hey @allo-,

You are very right! Would you like to open a PR to change it ? :-) Otherwise happy to do it !

patrickvonplaten avatar Nov 15 '22 21:11 patrickvonplaten

I don't think I can test all places from the commit. In the other PR, the test suite seems to fail as well in code unrelated to my changes. At least I've got quite a few bot mails about it.

How is the test coverage for the places changed in this commit (and maybe the previous ones. I had a look at the history of textual_inversion to find when it changed)?

allo- avatar Nov 15 '22 21:11 allo-

Will try to allocate time for this

patrickvonplaten avatar Nov 16 '22 20:11 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Dec 16 '22 15:12 github-actions[bot]

Here we go: https://github.com/huggingface/diffusers/pull/1778 -> won't have time to do the same changes for Flax though.

patrickvonplaten avatar Dec 19 '22 23:12 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 13 '23 15:01 github-actions[bot]