diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

added support for cifar10 and automatic resolution selection in training example

Open lukovnikov opened this issue 2 years ago • 5 comments

Added support for CIFAR10 in training example and automatic resolution selection + printing of param counts

lukovnikov avatar Nov 09 '22 19:11 lukovnikov

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@anton-l could you take a look here?

patrickvonplaten avatar Nov 09 '22 22:11 patrickvonplaten

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

This generally looks good to me :-) Could you leave the default to 64 though? And then maybe we'll just add a section in the README on how to run it for CIFAR?

What about changing default to "None" instead and changing the help description field so it's clear that the script chooses resolution based on dataset automatically? If not, I'll put 64 back :), I was just trying to unbloat the command line usage from redundant info.

lukovnikov avatar Nov 16 '22 19:11 lukovnikov

Let's add 64 back indeed, this way the choice of resolution will be explicit and controllable (e.g. for resolutions of more than 64, not only CIFAR and the existing examples)

anton-l avatar Dec 15 '22 15:12 anton-l

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 09 '23 15:01 github-actions[bot]