diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Fix lr-scaling store_true & default=True cli argument for textual_inversion training.

Open aredden opened this issue 3 years ago • 5 comments

action="store_true" means that the default action will be to set the value to False, and then if provided, set the value to True. Currently the default is manually set as 'True', therefore no-matter-what it will be True.

aredden avatar Oct 31 '22 21:10 aredden

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

This looks good to me - @patil-suraj what do you think?

patrickvonplaten avatar Nov 02 '22 16:11 patrickvonplaten

Gently ping here @patil-suraj - could you maybe go into the PR and finish it otherwise?

patrickvonplaten avatar Nov 16 '22 16:11 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Dec 11 '22 15:12 github-actions[bot]

cc @williamberman @pcuenca could you maybe take over here? :-)

patrickvonplaten avatar Dec 13 '22 17:12 patrickvonplaten

Will merge this and update the readme in follow-up PR.

patil-suraj avatar Jan 04 '23 14:01 patil-suraj