diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Annealed Langevin Sampler

Open natolambert opened this issue 1 year ago • 8 comments

Closes #84

Maybe @MinkaiXu can give a review on this?

natolambert avatar Oct 27 '22 18:10 natolambert

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@anton-l could you review here? :-)

patrickvonplaten avatar Oct 31 '22 18:10 patrickvonplaten

It would useful to compare this sampler to other samplers with the same prompt/seed/etc with images to see the difference it might have on images.

Suhail avatar Nov 02 '22 05:11 Suhail

@natolambert would it be possible to add an integration test with one of the existing models? Both for a usage example to understand the API (see Patrick's comment above), and for test coverage

anton-l avatar Nov 02 '22 13:11 anton-l

Yeah @anton-l and @Suhail I agree with both points. I'll do some experiments and share the results + tests

natolambert avatar Nov 02 '22 15:11 natolambert

Leaving open for now :-) Let me know if you require another review @natolambert - but I agree with @anton-l. We'd need some tests and also I think we might have to change the API regarding timesteps rather being indices.

patrickvonplaten avatar Nov 16 '22 16:11 patrickvonplaten

Yeah I'll come back to this when I have time. Mostly this was a learning side-project for me, so leaving open is preferred.

natolambert avatar Nov 16 '22 17:11 natolambert

What do people think. Is it worth spending time fleshing this out? SDE VE is the improved version of this scheduler, so unless we want to include it for completeness, it's not adding much.

Really it goes from NCSN to NCSNv2 to SDE VE/P.

We don't have the samplers for NCSN or NCSNv2 exactly. I could work to add them, but it may be better for a community member to pick this up?

natolambert avatar Nov 30 '22 01:11 natolambert

I think pretty much no-one uses SDE VE and SDE VP or Karras VE (<- this scheduler has a design that doesn't fit really anyways)

Think a community contributor could def take this over :-)

patrickvonplaten avatar Dec 01 '22 16:12 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Dec 26 '22 15:12 github-actions[bot]