deep-rl-class icon indicating copy to clipboard operation
deep-rl-class copied to clipboard

Published 20 hours ago • verified publisher icon huggingface

Advance Topics: New section for "RL for Trading"

Open ra9hur opened this issue 1 year ago • 5 comments

closes #555

ra9hur avatar Sep 01 '24 08:09 ra9hur

@simoninithomas ,

As suggested, have created this PR to include a section for "RL for Trading" in advance topics. Please review and let me know for any changes.

Thanks.

ra9hur avatar Sep 01 '24 13:09 ra9hur

Hi @dantp-ai , thanks for the detail reviews. I am slightly held up with another PR, will check your comments, make changes and re-submit by next weekend.

Thanks again !!

ra9hur avatar Sep 25 '24 07:09 ra9hur

Thanks @dantp-ai for your reviews !!

Just wanted to check if this is good to be merged and go live.

ra9hur avatar Oct 08 '24 12:10 ra9hur

@simoninithomas / @dantp-ai ,

Hope you are having a great day !! I assume, have fixed all review comments and the PR has been dormant for the last 3 weeks.

Was wondering if there is anything pending from my side. If you have been pondering on the topic relevance and whether to include this into the course material, understand. Please let me know either way.

ra9hur avatar Oct 26 '24 08:10 ra9hur

LGTM. Nothing from my side.

dantp-ai avatar Oct 26 '24 08:10 dantp-ai