unit2-push_to_hub

[fardinafdideh]

Hi,

• In unit2, in function "push_to_hub", the variable "env_id" has been used for the definition of variable "model_card". This variable, "env_id", hasn't been defined in the function "push_to_hub", and it uses a variable from outside of the function which is not necessarily the right value. It should be replaced with "model["env_id"]", i.e., "env_id" -> "model["env_id"]".

• Model card is not updated when a new push is done, so I commented the following lines:

  readme = "" print(readme_path.exists()) if readme_path.exists(): with readme_path.open("r", encoding="utf8") as f: readme = f.read() else: readme = model_card

and added "readme = model_card", so that the model card is updated for each push.

[simoninithomas]

Thanks for pointing this out I’m adding this for the december update